Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112603375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
ResolveGroupingAnalytics ::
ResolvePivot ::
ResolveOrdinalInOrderByAndGroupBy ::
+ ResolveAggAliasInGroupBy ::
--- End diff --
is it safer to put it in an individual batch after the `resolution` batch?
Ideally we should only run this rule if we make sure there is no other way to
resolve the grouping expressions exception this rule. cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
