Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17684#discussion_r112620153 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -132,14 +132,22 @@ final class Decimal extends Ordered[Decimal] with Serializable { } /** - * Set this Decimal to the given BigInteger value. Will have precision 38 and scale 0. + * Set this Decimal to the given BigInteger value. Will have precision 38 and scale 0 + * if value is fit into long value range. Otherwise, use BigDecimal --- End diff -- How about > If the value is not in the range of long, convert it to BigDecimal and the precision and scale is based on the converted value.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org