Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17683#discussion_r112631811
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -497,11 +497,18 @@ private[spark] class BlockManagerInfo(
updateLastSeenMs()
+ var blockExists = false
--- End diff --
Although you could just assign `val blockExists =
_blocks.containsKey(blockId)` once and reuse it instead of a `var`, it's minor.
This looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
