Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17697#discussion_r112758437
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/rdd/MLPairRDDFunctions.scala ---
@@ -39,8 +39,8 @@ class MLPairRDDFunctions[K: ClassTag, V: ClassTag](self:
RDD[(K, V)]) extends Se
* @param ord the implicit ordering for T
* @return an RDD that contains the top k values for each key
*/
- def topByKey(num: Int)(implicit ord: Ordering[V]): RDD[(K, Array[V])] = {
- self.aggregateByKey(new BoundedPriorityQueue[V](num)(ord))(
+ def topByKey(num: Int, bucketsCount: Int = 200)(implicit ord:
Ordering[V]): RDD[(K, Array[V])] = {
--- End diff --
Can we just add another overloaded method rather than fixing existing one?
I guess probably this case is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
