Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17723#discussion_r112788867
  
    --- Diff: core/pom.xml ---
    @@ -357,6 +357,34 @@
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-crypto</artifactId>
         </dependency>
    +
    +    <!--
    +     Testing Hive reflection needs hive on the test classpath only.
    +     It doesn't need the spark hive modules, so the -Phive flag is not 
checked.
    +      -->
    +    <dependency>
    +      <groupId>${hive.group}</groupId>
    +      <artifactId>hive-exec</artifactId>
    --- End diff --
    
    I still don't know how to place these in the `test` scope, which is where 
they belong.  See my comment here: 
https://github.com/apache/spark/pull/17665/files#r112337820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to