GitHub user markgrover opened a pull request:
https://github.com/apache/spark/pull/17725
[SPARK-20435][CORE] More thorough redaction of sensitive information
This change does a more thorough redaction of sensitive information from
logs and UI
Add unit tests that ensure that no regressions happen that leak sensitive
information to the logs.
Previously redaction logic was only checking if the key matched the secret
regex pattern, it'd redact it's value. That worked for most cases. However, in
the above case, the key (sun.java.command) doesn't tell much, so the value
needs to be searched. This PR expands the check to check for values as well.
## How was this patch tested?
New unit tests added that ensure that no sensitive information is present
in the event logs or the yarn logs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markgrover/spark spark-20435
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17725
----
commit 2f5148a2e37d8d36006fb297b28a9e8c21a0026b
Author: Mark Grover <m...@apache.org>
Date: 2017-04-22T00:24:30Z
[SPARK-20435][CORE] More thorough redaction of sensitive information from
logs/UI, more unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
