Github user map222 commented on a diff in the pull request: https://github.com/apache/spark/pull/17737#discussion_r113001678 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -1008,7 +1009,7 @@ class Column(val expr: Expression) extends Logging { def cast(to: String): Column = cast(CatalystSqlParser.parseDataType(to)) /** - * Returns an ordering used in sorting. + * Returns a sort expression based on the descending order of the column. --- End diff -- Do you want to include example usages, as in the python documentation? E.g. for rlike, ``` * {{{ * // find names that start with "Al" * scala> df.filter( $"name".like("Al%") ).collect() * Array([Alice,1]) * }}} ``` It would also be helpful for the `startsWith` and `endsWith` functions, where there are two versions, e.g. `startsWith(other: Column)` and `startsWith(literal: String)`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org