Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2480#discussion_r17845815
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1270,13 +1270,12 @@ abstract class RDD[T: ClassTag](
* doCheckpoint() is called recursively on the parent RDDs.
*/
private[spark] def doCheckpoint() {
- if (!doCheckpointCalled) {
- doCheckpointCalled = true
- if (checkpointData.isDefined) {
- checkpointData.get.doCheckpoint()
- } else {
- dependencies.foreach(_.rdd.doCheckpoint())
- }
+ if (checkpointData == None && doCheckpointCalled == 0) {
--- End diff --
There is no explanation of what this change is trying to accomplish. What
do you believe this fixes? I would not use "1" and "2" to represent some kind
of state without explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
