Github user Krimit commented on the issue:
https://github.com/apache/spark/pull/17673
I'm happy to take a look! I'll have some time to dig in deeper tomorrow.
Some of my initial impressions:
* There's a lot going on here, I agree with @hhbyyh that it would be
cleaner to put the CBOW code in a new class
* Can you provide some information about the practical differences between
CBOW and skip-grams? Wikipedia quotes the author (I assume they mean Tomas) as
saying that ``CBOW is faster while skip-gram is slower but does a better job
for infrequent words``. Has this been your experience as well? How pronounced
is the difference? in what cases would a user choose one over the other? I'm
basically seconding @hhbyyh's comment on a more in-depth comparison experiment.
The fact that the original paper has both implementations is not in itself
enough of a reason for Spark to do the same, IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
