Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17649#discussion_r113427428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -295,7 +295,9 @@ class InMemoryCatalog(
assert(tableDefinition.identifier.database.isDefined)
val db = tableDefinition.identifier.database.get
requireTableExists(db, tableDefinition.identifier.table)
- catalog(db).tables(tableDefinition.identifier.table).table =
tableDefinition
+ val updatedProperties = tableDefinition.properties.filter(kv => kv._1
!= "comment")
+ val newTableDefinition = tableDefinition.copy(properties =
updatedProperties)
+ catalog(db).tables(tableDefinition.identifier.table).table =
newTableDefinition
--- End diff --
@gatorsmile @wzhfy as i noticed for hive tables already the 'comment'
property is been filtered while getting the hive table metadata(reading) in
**HiveClientImpl.scala** -- > **getTableOption()** API. so i think it will be
better if we can do the same for **InMemoryCatalogs** type table, while reading
the table metadata we can exclude the 'comment', i think if we exclude from
table definition while alter command then there can be an inconsistency,
eg: In create table we will persist the comment in metadata and while
altering we are not.
Please correct me if i am going in wrong direction, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
