Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/17776#discussion_r113586358
--- Diff:
sql/core/src/test/resources/sql-tests/results/sql-compatibility-functions.sql.out
---
@@ -102,7 +102,7 @@ true 1 1 1 1
-- !query 10
SELECT float(1), double(1), decimal(1)
-- !query 10 schema
-struct<CAST(1 AS FLOAT):float,CAST(1 AS DOUBLE):double,CAST(1 AS
DECIMAL(10,0)):decimal(10,0)>
+struct<CAST(1 AS FLOAT):float,CAST(1 AS DOUBLE):double,CAST(1 AS
DECIMAL(100)):decimal(10,0)>
--- End diff --
Hi, @gatorsmile . The PR looks good. BTW, could we make `DECIMAL(10 0)`
instead of `DECIMAL(100)` by changing
[DecimalType](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala#L66)
together in this PR?
```
- override def typeName: String = s"decimal($precision,$scale)"
+ override def typeName: String = s"decimal($precision, $scale)"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
