Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17770#discussion_r113641661 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -702,7 +705,7 @@ class Dataset[T] private[sql]( * @since 2.0.0 */ def join(right: Dataset[_]): DataFrame = withPlan { - Join(logicalPlan, right.logicalPlan, joinType = Inner, None) + Join(AnalysisBarrier(logicalPlan), right.logicalPlan, joinType = Inner, None) --- End diff -- I am wondering if we should check there's duplication between right and left sides and decide using barrier or not for right side.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org