Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17789#discussion_r113822807
  
    --- Diff: 
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
    @@ -169,7 +177,12 @@ private[spark] object ReliableCheckpointRDD extends 
Logging {
         val bufferSize = env.conf.getInt("spark.buffer.size", 65536)
     
         val fileOutputStream = if (blockSize < 0) {
    -      fs.create(tempOutputPath, false, bufferSize)
    +      val fileStream = fs.create(tempOutputPath, false, bufferSize)
    +      if (env.conf.get(CHECKPOINT_COMPRESS)) {
    +        
CompressionCodec.createCodec(env.conf).compressedOutputStream(fileStream)
    --- End diff --
    
    A question I had even with the earlier PR was - should we add the extension 
to either the directory or the file indicating compression type ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to