Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17801#discussion_r113879810 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2487,19 +2487,21 @@ object functions { */ def current_timestamp(): Column = withExpr { CurrentTimestamp() } + // scalastyle:off line.size.limit /** * Converts a date/timestamp/string to a value of string in the format specified by the date * format given by the second argument. * * A pattern could be for instance `dd.MM.yyyy` and could return a string like '18.03.1993'. All - * pattern letters of `java.text.SimpleDateFormat` can be used. + * pattern letters of [[https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html java.text.SimpleDateFormat]] can be used. --- End diff -- We don't generally link to external javadoc, and we've had problems creating a normal javadoc link to the class in many instances. For consistency, I wouldn't bother with this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org