Github user zero323 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17783#discussion_r113992412
--- Diff: R/pkg/R/column.R ---
@@ -67,8 +67,7 @@ operators <- list(
"+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" =
"mod",
"==" = "equalTo", ">" = "gt", "<" = "lt", "!=" = "notEqual", "<=" =
"leq", ">=" = "geq",
# we can not override `&&` and `||`, so use `&` and `|` instead
- "&" = "and", "|" = "or", #, "!" = "unary_$bang"
- "^" = "pow"
+ "&" = "and", "|" = "or", "^" = "pow"
--- End diff --
Since this PR implements `!` I think it is just confusing, don't you? Not
to mention that `createOperator` didn't work with `!`. I can restore it if you
believe it serves some purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
