Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/17715#discussion_r114032804
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -312,6 +390,71 @@ class LogisticRegression @Since("1.2.0") (
def setAggregationDepth(value: Int): this.type = set(aggregationDepth,
value)
setDefault(aggregationDepth -> 2)
+ /**
+ * Set the lower bounds on coefficients if fitting under bound
constrained optimization.
+ *
+ * @group setParam
+ */
+ @Since("2.2.0")
+ def setLowerBoundsOnCoefficients(value: Matrix): this.type =
set(lowerBoundsOnCoefficients, value)
+
+ /**
+ * Set the upper bounds on coefficients if fitting under bound
constrained optimization.
+ *
+ * @group setParam
+ */
+ @Since("2.2.0")
+ def setUpperBoundsOnCoefficients(value: Matrix): this.type =
set(upperBoundsOnCoefficients, value)
+
+ /**
+ * Set the lower bounds on intercepts if fitting under bound constrained
optimization.
+ *
+ * @group setParam
+ */
+ @Since("2.2.0")
+ def setLowerBoundsOnIntercepts(value: Vector): this.type =
set(lowerBoundsOnIntercepts, value)
+
+ /**
+ * Set the upper bounds on intercepts if fitting under bound constrained
optimization.
+ *
+ * @group setParam
+ */
+ @Since("2.2.0")
+ def setUpperBoundsOnIntercepts(value: Vector): this.type =
set(upperBoundsOnIntercepts, value)
+
+ private def assertBoundConstrainedOptimizationParamsValid(
+ numCoefficientSets: Int,
+ numFeatures: Int): Unit = {
+ if (isSet(lowerBoundsOnCoefficients)) {
+ require($(lowerBoundsOnCoefficients).numRows == numCoefficientSets &&
+ $(lowerBoundsOnCoefficients).numCols == numFeatures)
+ }
+ if (isSet(upperBoundsOnCoefficients)) {
+ require($(upperBoundsOnCoefficients).numRows == numCoefficientSets &&
+ $(upperBoundsOnCoefficients).numCols == numFeatures)
+ }
+ if (isSet(lowerBoundsOnIntercepts)) {
+ require($(lowerBoundsOnIntercepts).size == numCoefficientSets)
+ }
+ if (isSet(upperBoundsOnIntercepts)) {
+ require($(upperBoundsOnIntercepts).size == numCoefficientSets)
+ }
+ if (isSet(lowerBoundsOnCoefficients) &&
isSet(upperBoundsOnCoefficients)) {
+
require($(lowerBoundsOnCoefficients).toArray.zip($(upperBoundsOnCoefficients).toArray)
+ .forall(x => x._1 <= x._2), "LowerBoundsOnCoefficients should
always " +
--- End diff --
always => always be
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
