Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r114088733 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1086,10 +1106,22 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging { /** * Create a function database (optional) and name pair. */ - protected def visitFunctionName(ctx: QualifiedNameContext): FunctionIdentifier = { + protected def visitFunctionName( + ctx: QualifiedNameContext, + trimFuncN: Option[String] = None): FunctionIdentifier = { ctx.identifier().asScala.map(_.getText) match { - case Seq(db, fn) => FunctionIdentifier(fn, Option(db)) - case Seq(fn) => FunctionIdentifier(fn, None) + case Seq(db, fn) => + if (fn.equalsIgnoreCase("trim") && trimFuncN.isDefined) { --- End diff -- oh. got it. It is stored in `trimFuncN`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org