Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/17813#discussion_r114166338
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -589,8 +605,18 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
// take into account executors that are pending to be added or
removed.
val adjustTotalExecutors =
if (!replace) {
- doRequestTotalExecutors(
- numExistingExecutors + numPendingExecutors -
executorsPendingToRemove.size)
+ requestedTotalExecutors = math.max(requestedTotalExecutors -
executorsToKill.size, 0)
+ if (requestedTotalExecutors !=
+ (numExistingExecutors + numPendingExecutors -
executorsPendingToRemove.size)) {
+ logInfo(
+ s"""killExecutors($executorIds, $replace, $force): Executor
counts do not match:
+ |requestedTotalExecutors = $requestedTotalExecutors
+ |numExistingExecutors = $numExistingExecutors
+ |numPendingExecutors = $numPendingExecutors
+ |executorsPendingToRemove =
${executorsPendingToRemove.size}
+ """.stripMargin)
--- End diff --
Thanks, I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
