Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17827#discussion_r114244470 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala --- @@ -284,23 +287,6 @@ class ColumnExpressionSuite extends QueryTest with SharedSQLContext { test("<=>") { checkAnswer( - testData2.filter($"a" === 1), - testData2.collect().toSeq.filter(r => r.getInt(0) == 1)) - - checkAnswer( - testData2.filter($"a" === $"b"), - testData2.collect().toSeq.filter(r => r.getInt(0) == r.getInt(1))) --- End diff -- The test below: ```scala checkAnswer( testData2.filter($"a" === 1), testData2.collect().toSeq.filter(r => r.getInt(0) == 1)) checkAnswer( testData2.filter($"a" === $"b"), testData2.collect().toSeq.filter(r => r.getInt(0) == r.getInt(1))) ``` looked to me identical with the test for `===` above and not testing `<=>`. So I removed this as a duplicated test.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org