GitHub user weilan007 opened a pull request:
https://github.com/apache/spark/pull/2507
Potential error of message construction of SCC
Hi,
According to the
[paper](http://ilpubs.stanford.edu:8090/1077/3/p535-salihoglu.pdf), I think the
message passing condition written in line 78 should be
```scala
e.srcAttr._1 < e.dstAttr._1
```
instead of the previous one, because the `srcAttr._1` and `dstAttr._1` are
the `colorId` in **Forward-Traversal** phase, as written in the paper.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weilan007/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2507
----
commit 3b0a14459188b03f8b0c9b96af79c43ffc850dfe
Author: weilan007 <panda_...@qq.com>
Date: 2014-09-23T09:25:22Z
Potential error of message construction of SCC
Hi,
According to the
[paper](http://ilpubs.stanford.edu:8090/1077/3/p535-salihoglu.pdf), I think the
message passing condition written in line 78 should be
```scala
e.srcAttr._1 < e.dstAttr._1
```
instead of the previous one, because the `srcAttr._1` and `dstAttr._1` are
the `colorId` in **Forward-Traversal** phase, as written in the paper.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
