Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/17849
@jkbradley @holdenk the heart of this change is just adding the call to
`_copyValues` to copy param values from Estimator to Model. That doesn't
really do much though, since most of the Python models do not define any params
and there is nothing to copy to. So I added a temporary little hack to look
at the Java Model params after fitting and create any params that don't already
exist, then any set values can be copied. Also needed to do the same after
loading a Python model or this will fail persistence tests.
I know having this temporary 'fix' isn't ideal but it would allow us to
incrementally add missing Params or restructure class hierarchy to match Scala
versions and will continue to copy these values to the Models. Until that is
done, there won't be explicit methods to get each param, such as
`getMaxDepth()` but the param value can still be accessed by
`param.getOrDefault("maxDepth")` to give users a workaround for all of those
type of JIRAs that have come up. What do you guys think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
