Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17851#discussion_r114698385
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -3715,3 +3715,34 @@ setMethod("rollup",
                 sgd <- callJMethod(x@sdf, "rollup", jcol)
                 groupedData(sgd)
               })
    +
    +#' hint
    +#'
    +#' Specifies execution plan hint on the current SparkDataFrame.
    --- End diff --
    
    the R programming model is a bit different - I think it is better to point 
out the original SparkDataFrame is not actually changed - instead say `.... 
hint and return a new SparkDataFrame` is better


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to