Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16989#discussion_r114769949
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -100,7 +114,14 @@ public void onSuccess(ByteBuffer response) {
// Immediately request all chunks -- we expect that the total
size of the request is
// reasonable due to higher level chunking in
[[ShuffleBlockFetcherIterator]].
for (int i = 0; i < streamHandle.numChunks; i++) {
- client.fetchChunk(streamHandle.streamId, i, chunkCallback);
+ if (fetchToDisk) {
+ final File targetFile = new File(".",
--- End diff --
instead of passing a `boolean fetchToDisk`, shall we ask the caller to pass
in `Option<File> file`? My concern is that, Spark has a rule about where to
write temp files, we can't just write it to the current directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
