Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/17467#discussion_r114922000
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -60,12 +61,19 @@ private[kinesis] class KinesisInputDStream[T: ClassTag](
val isBlockIdValid = blockInfos.map { _.isBlockIdValid() }.toArray
logDebug(s"Creating KinesisBackedBlockRDD for $time with
${seqNumRanges.length} " +
s"seq number ranges: ${seqNumRanges.mkString(", ")} ")
+
+ /**
+ * Construct the Kinesis read configs from streaming context
+ * and pass to KinesisBackedBlockRDD
+ */
+ val kinesisReadConfigs = KinesisReadConfigurations(ssc)
+
new KinesisBackedBlockRDD(
context.sc, regionName, endpointUrl, blockIds, seqNumRanges,
isBlockIdValid = isBlockIdValid,
- retryTimeoutMs = ssc.graph.batchDuration.milliseconds.toInt,
messageHandler = messageHandler,
- kinesisCreds = kinesisCreds)
+ kinesisCreds = kinesisCreds,
+ kinesisReadConfigs = kinesisReadConfigs)
--- End diff --
I think it would be sufficient to change this to
```scala
kinesisReadConfigs = KinesisReadConfigurations(ssc))
```
and omit lines 65-70. I don't think a comment is necessary here, the code
is pretty straightforward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
