Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17844#discussion_r115098412
--- Diff:
repl/scala-2.11/src/test/scala/org/apache/spark/repl/SingletonReplSuite.scala
---
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.repl
+
+import java.io._
+import java.net.URLClassLoader
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.commons.lang3.StringEscapeUtils
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.util.Utils
+
+/**
+ * A special test suite for REPL that all test cases share one REPL
instance.
+ */
+class SingletonReplSuite extends SparkFunSuite {
+
+ private val out = new StringWriter()
+ private val in = new PipedOutputStream()
+ private var thread: Thread = _
+
+ private val CONF_EXECUTOR_CLASSPATH = "spark.executor.extraClassPath"
+ private val oldExecutorClasspath =
System.getProperty(CONF_EXECUTOR_CLASSPATH)
+
+ override def beforeAll(): Unit = {
+ super.beforeAll()
+
+ val cl = getClass.getClassLoader
+ var paths = new ArrayBuffer[String]
+ if (cl.isInstanceOf[URLClassLoader]) {
+ val urlLoader = cl.asInstanceOf[URLClassLoader]
+ for (url <- urlLoader.getURLs) {
+ if (url.getProtocol == "file") {
+ paths += url.getFile
+ }
+ }
+ }
+ val classpath = paths.map(new
File(_).getAbsolutePath).mkString(File.pathSeparator)
+
+ System.setProperty(CONF_EXECUTOR_CLASSPATH, classpath)
+ Main.conf.set("spark.master", "local-cluster[2,4,4096]")
+ val interp = new SparkILoop(
+ new BufferedReader(new InputStreamReader(new PipedInputStream(in))),
+ new PrintWriter(out))
+
+ // Forces to create new SparkContext
+ Main.sparkContext = null
+ Main.sparkSession = null
+
+ // Starts a new thread to run the REPL interpreter, so that we won't
block.
+ thread = new Thread(new Runnable {
--- End diff --
nit: please call `Thread.setDaemon(true)` in case that something is wrong
and it prevents the process from exiting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
