Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17540#discussion_r115229230
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -283,44 +283,57 @@ class StreamExecution(
// Unblock `awaitInitialization`
initializationLatch.countDown()
- triggerExecutor.execute(() => {
- startTrigger()
-
- if (isActive) {
- reportTimeTaken("triggerExecution") {
- if (currentBatchId < 0) {
- // We'll do this initialization only once
- populateStartOffsets(sparkSessionToRunBatches)
-
sparkSession.sparkContext.setJobDescription(getBatchDescriptionString)
- logDebug(s"Stream running from $committedOffsets to
$availableOffsets")
- } else {
- constructNextBatch()
+ // execution hasn't started, so lastExecution isn't defined.
create an IncrementalExecution
+ // with the logical plan for the SQL listener using the current
initialized values.
+ val genericStreamExecution = new IncrementalExecution(
+ sparkSessionToRunBatches,
+ logicalPlan,
+ outputMode,
+ checkpointFile("state"),
+ currentBatchId,
+ offsetSeqMetadata)
+
+ SQLExecution.withNewExecutionId(sparkSessionToRunBatches,
genericStreamExecution) {
--- End diff --
I think we should have an execution id for each streaming batch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
