Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115361494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object ResolveTableValuedFunctions extends
Rule[LogicalPlan] {
* A TVF maps argument lists to resolver functions that accept those
arguments. Using a map
* here allows for function overloading.
*/
- private type TVF = Map[ArgumentList, Seq[Any] => LogicalPlan]
+ private type TVF = Map[ArgumentList, (UnresolvedTableValuedFunction,
Seq[Any]) => LogicalPlan]
/**
* TVF builder.
*/
- private def tvf(args: (String, DataType)*)(pf: PartialFunction[Seq[Any],
LogicalPlan])
- : (ArgumentList, Seq[Any] => LogicalPlan) = {
+ private def tvf(args: (String, DataType)*)(
+ pf: PartialFunction[(UnresolvedTableValuedFunction, Seq[Any]),
LogicalPlan])
--- End diff --
I also think that we should separate the aliasing from constructing the
table valued function
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
