Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17928#discussion_r115663190
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,15 +472,23 @@ identifierComment
;
relationPrimary
- : tableIdentifier sample? (AS? strictIdentifier)?
#tableName
- | '(' queryNoWith ')' sample? (AS? strictIdentifier)?
#aliasedQuery
- | '(' relation ')' sample? (AS? strictIdentifier)?
#aliasedRelation
- | inlineTable
#inlineTableDefault2
- | identifier '(' (expression (',' expression)*)? ')'
#tableValuedFunction
+ : tableIdentifier sample? (AS? strictIdentifier)? #tableName
+ | '(' queryNoWith ')' sample? (AS? strictIdentifier)? #aliasedQuery
+ | '(' relation ')' sample? (AS? strictIdentifier)? #aliasedRelation
+ | inlineTable
#inlineTableDefault2
+ | functionTable
#tableValuedFunction
;
inlineTable
- : VALUES expression (',' expression)* (AS? identifier
identifierList?)?
+ : VALUES expression (',' expression)* tableAlias
+ ;
+
+functionTable
+ : identifier '(' (expression (',' expression)*)? ')' tableAlias
+ ;
+
+tableAlias
+ : (AS? strictIdentifier identifierList?)?
--- End diff --
This also hits another bug in inline tables. Maybe you also can include the
following query in the test case `inline-table.sql`?
```
sql("SELECT * FROM VALUES (\"one\", 1), (\"two\", 2), (\"three\", null)
CROSS JOIN VALUES (\"one\", 1), (\"two\", 2), (\"three\", null)")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
