Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17933#discussion_r115690941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -954,8 +955,9 @@ case class FromUTCTimestamp(left: Expression, right:
Expression)
val tzTerm = ctx.freshName("tz")
val utcTerm = ctx.freshName("utc")
val tzClass = classOf[TimeZone].getName
- ctx.addMutableState(tzClass, tzTerm, s"""$tzTerm =
$tzClass.getTimeZone("$tz");""")
- ctx.addMutableState(tzClass, utcTerm, s"""$utcTerm =
$tzClass.getTimeZone("UTC");""")
+ val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
--- End diff --
Is it more efficient to save this value in a static (object) member
somewhere or will it not matter much? I see it's used several times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
