Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/16985#discussion_r116162386
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -315,8 +317,14 @@ abstract class BucketedReadSuite extends QueryTest
with SQLTestUtils {
assert(
joinOperator.right.find(_.isInstanceOf[SortExec]).isDefined ==
sortRight,
s"expected sort in the right child to be $sortRight but
found\n${joinOperator.right}")
+
+ if (expectedResult.isDefined) {
+ checkAnswer(joined, expectedResult.get)
--- End diff --
This will let us validate against some predefined expected output.
L296 will recompute the result with the exact same `joinCondition`... but
for my test case I don't want to reuse the same `joinCondition`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
