Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17940#discussion_r116351996
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala 
---
    @@ -992,7 +992,24 @@ object Matrices {
             new DenseMatrix(dm.rows, dm.cols, dm.data, dm.isTranspose)
           case sm: BSM[Double] =>
             // There is no isTranspose flag for sparse matrices in Breeze
    -        new SparseMatrix(sm.rows, sm.cols, sm.colPtrs, sm.rowIndices, 
sm.data)
    +
    +        // Some Breeze CSCMatrices may have extra trailing zeros in
    --- End diff --
    
    minor: make this comment more impact in fewer lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to