Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17973#discussion_r116354253
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -622,6 +622,31 @@ class CSVSuite extends QueryTest with SharedSQLContext
with SQLTestUtils {
}
}
+ test("save tsv with tsv suffix") {
+ withTempDir { dir =>
+ val csvDir = new File(dir, "csv").getCanonicalPath
+ val cars = spark.read
+ .format("csv")
+ .option("header", "true")
+ .load(testFile(carsFile))
+
+ cars.coalesce(1).write
+ .option("header", "true")
+ .option("fileExtension", ".tsv")
+ .option("delimiter", "\t")
--- End diff --
I guess the whole API and implementation is called "CSV" still. Of course,
you can already read/write files with different names and different delimiters.
Does this matter enough to make a new option? what if I delimit with, eh, null
characters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
