Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17910#discussion_r116408136
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2318,8 +2319,8 @@ class LogisticRegressionSuite
assert(m1.interceptVector ~== m2.interceptVector absTol 0.05)
}
val testParams = Seq(
- ("binomial", smallBinaryDataset, 2),
- ("multinomial", smallMultinomialDataset, 3)
+ ("Binomial", smallBinaryDataset, 2),
--- End diff --
The changes you made don't address this comment at all, and there are not
tests for the suggestion from Yanbo either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
