Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17985#discussion_r116572426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
---
@@ -24,7 +24,7 @@ import org.apache.spark.sql.catalyst.expressions.Attribute
object JoinType {
def apply(typ: String): JoinType =
typ.toLowerCase(Locale.ROOT).replace("_", "") match {
case "inner" => Inner
- case "outer" | "full" | "fullouter" => FullOuter
+ case "outer" | "full" | "fullouter" | "full_outer" => FullOuter
--- End diff --
as @wzhfy points out, given that we remove underscores, this matching case
is unnecessary. The same is true for `left_outer`, `right_outer` and
`left_semi`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
