Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17680#discussion_r116579008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -235,3 +238,39 @@ private[parquet] object ParquetFilters { } } } + +/** + * Note that, this is a hacky workaround to allow dots in column names. Currently, column APIs + * in Parquet's `FilterApi` only allows dot-separated names so here we resemble those columns + * but only allow single column path that allows dots in the names as we don't currently push + * down filters with nested fields. --- End diff -- We need to explain the functions in this object `ParquetColumns` are based on the codes in `org.apache.parquet.filter2.predicate`. Thus, when upgrading the Parquet versions, we need to check whether they are still the same.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org