Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r116906282
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -278,4 +278,10 @@ package object config {
             "spark.io.compression.codec.")
           .booleanConf
           .createWithDefault(false)
    +  private[spark] val SHUFFLE_ACCURATE_BLOCK_THRESHOLD =
    +    ConfigBuilder("spark.shuffle.accurateBlkThreshold")
    +      .doc("This only works in HighlyCompressedMapStatus. Sizes of blocks 
above this threshold" +
    +        " will be recorded accurately. This is to help control memory cost 
when shuffle blocks.")
    --- End diff --
    
    how about
    ```
    When we compress the size of shuffle blocks in HighlyCompressedMapStatus, 
we will record the size accurately if it's above the threshold specified by 
this config. This helps to prevent OOM by avoiding underestimating shuffle 
block size when fetching shuffle blocks.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to