Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17997#discussion_r116930879
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -96,6 +99,8 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
}
}
+ checkEvaluation(Year(Literal(new Date(sdf.parse("1582-01-01
13:10:15").getTime))), 1582)
+ checkEvaluation(Year(Literal(new Date(sdf.parse("1582-12-31
13:10:15").getTime))), 1582)
--- End diff --
Here should be `1581-12-31` and `1582-01-01`, for example, and the rest
should be in a similar way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
