Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2516#issuecomment-56745901
Hi @tigerquoll ,
Overall I like the idea of making this code saner. But your patch currently
has a ton of style issues, several bugs (e.g. leaking open files in several
spots), and some APIs that just look redundant.
Also, it makes some decisions that I'm don't agree very much with. e.g.,
turn "primaryResource" or "mainClass" into configuration values. Unless doing
that makes the final code a lot cleaner, I'd rather see them treated as what
they really are: required command line arguments.
I made a lot of comments but I definitely could use a second or third go
through the code. It's a large patch and it's really easy to miss things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
