Github user sethah commented on the issue:
https://github.com/apache/spark/pull/13959
This is fine, but are we not also policing JIRAs? I've argued above that
the reason this PR has been inactive is simply lack of interest in this issue.
If that's the case, then the JIRA must also be closed, since we've implicitly
decided that this is no longer or never was a problem worth solving.
If it is not the case, then we must absolutely leave this open - since this
is a.) still unsolved b.) good code c.) still of interest. The reason for
closing PRs but _not_ their corresponding JIRA would be that the PR is either
poorly implemented or the author is non-responsive. While it is no doubt
frustrating for contributors to submit code that is well-written and solves a
problem that a project committer asked for, I also don't know that leaving it
open indefinitely is a solution either. I guess I don't understand why we'd be
willing to leave JIRAs open indefinitely but not PRs. At any rate, in this case
I would have proposed we ask for Joseph's (issue creator) input for a few days,
and if we hear nothing close both JIRA and PR. We surely do not want others to
submit patches for this issue if it will not be reviewed and merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
