Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17955#discussion_r117385673
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1233,17 +1223,6 @@ class DAGScheduler(
logInfo("waiting: " + waitingStages)
logInfo("failed: " + failedStages)
- // We supply true to increment the epoch number here in case
this is a
- // recomputation of the map outputs. In that case, some
nodes may have cached
- // locations with holes (from when we detected the error)
and will need the
- // epoch incremented to refetch them.
- // TODO: Only increment the epoch number if this is not the
first time
- // we registered these map outputs.
- mapOutputTracker.registerMapOutputs(
- shuffleStage.shuffleDep.shuffleId,
- shuffleStage.outputLocInMapOutputTrackerFormat(),
- changeEpoch = true)
--- End diff --
Is it safer if we increment the epoch number here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
