Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/16648
I see. I understand two facts.
1. We can split this into two changes from the implementation view.
2. We cannot fix the [test
cause](https://github.com/apache/spark/pull/16648/files#diff-c7f041fda7fd9aa1a5225f86bab4b1b0R69)
by only one change.
In my personal opinion, it would be good to split this into two PRs while I
understand Fact 2. IIUC, the review is performed based on each PR, not each
commit. To split it into two PRs would make review easier.
What do you think?
If you make the first PR, you could put the test case with smaller columns.
Then, when you will make another PR, you could update it with larger columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
