GitHub user MrBago opened a pull request:

    https://github.com/apache/spark/pull/18081

    [SPARK-20862] BugFix - avoid passing float to ndarray.reshape in 
LogisticRegressionModel

    ## What changes were proposed in this pull request?
    
    Fixed TypeError with python3 and numpy 1.12.1. Numpy's `reshape` no longer 
takes floats as arguments as of 1.12. Also, python3 uses float division for 
`/`, we should be using `//` to ensure that `_dataWithBiasSize` doesn't get set 
to a float.
    
    ## How was this patch tested?
    
    Existing tests run using python3 and numpy 1.12.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MrBago/spark BF-py3floatbug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18081
    
----
commit b53616026eac18d4e49bf5a60e077f7226afc951
Author: Bago Amirbekian <b...@databricks.com>
Date:   2017-05-24T01:01:45Z

    BugFix - avoid passing float to ndarray.reshape in LogisticRegressionModel.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to