GitHub user ConeyLiu opened a pull request:

    https://github.com/apache/spark/pull/18090

    [SPARK-20250][Core]Improper OOM error when a task been killed while 
spilling data

    
    ## What changes were proposed in this pull request?
    
    Currently, when a task is calling spill() but it receives a killing request 
from driver (e.g., speculative task), the TaskMemoryManager will throw an OOM 
exception.  And we don't catch `NonFatal` exception when a error caused by 
`Thread.interrupt`. So for `ClosedByInterruptException`, we should throw 
`RuntimeException` instead of `OutOfMemoryError`.
    
    https://issues.apache.org/jira/browse/SPARK-20250?jql=project%20%3D%20SPARK
    
    
    ## How was this patch tested?
    
    Existing unit tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ConeyLiu/spark SPARK-20250

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18090
    
----
commit 1a45ff5ced6cffd3d8ed41574df3bdd8e463bc21
Author: Xianyang Liu <xianyang....@intel.com>
Date:   2017-05-24T15:10:20Z

    throw RuntimeException against OutOfMemoryError when a task been killed 
while spilling data

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to