Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/18092#discussion_r118327566
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -174,14 +174,18 @@ private[spark] class BlockManager(
// standard BlockTransferService to directly connect to other Executors.
private[spark] val shuffleClient = if (externalShuffleServiceEnabled) {
val transConf = SparkTransportConf.fromSparkConf(conf, "shuffle",
numUsableCores)
- new ExternalShuffleClient(transConf, securityManager,
securityManager.isAuthenticationEnabled())
+ new ExternalShuffleClient(transConf, securityManager,
securityManager.isAuthenticationEnabled(), registrationTimeout)
} else {
blockTransferService
}
// Max number of failures before this block manager refreshes the block
locations from the driver
private val maxFailuresBeforeLocationRefresh =
conf.getInt("spark.block.failures.beforeLocationRefresh", 5)
+ private val registrationTimeout =
--- End diff --
Please use conf.getTimeAsMs instead of getInt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
