Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12414#discussion_r118391881
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -163,12 +163,20 @@ class RFormula @Since("1.5.0") (@Since("1.5.0")
override val uid: String)
}.toMap
// Then we handle one-hot encoding and interactions between terms.
+ var hasReferenceCategory = false
--- End diff --
I think this is just used as an indicator whether a `dropLast(false)` has
been set.
However, I do think we can have better name than `hasReferenceCategory`.
Basically what's needed is just set `dropLast(false)` for the first string.
How about something like this:
```
var firstString = true
if (!hasIntercept && firstString) {
encoder = encoder.setDropLast(false)
firstString = false
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
