Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18057#discussion_r118437741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -232,9 +232,10 @@ case class Ceil(child: Expression) extends
UnaryMathExpression(math.ceil, "CEIL"
}
override def inputTypes: Seq[AbstractDataType] =
- Seq(TypeCollection(DoubleType, DecimalType))
+ Seq(TypeCollection(DoubleType, LongType, DecimalType))
--- End diff --
I don't think we should modify the change from what we did at `master` when
backporting as far as possible .
If you want to modify this, let's submit another pr to `master` first, and
then backport it too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
