Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18064#discussion_r118440922
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -426,36 +418,35 @@ case class DataSource(
// For partitioned relation r, r.schema's column ordering can be
different from the column
// ordering of data.logicalPlan (partition columns are all moved after
data column). This
// will be adjusted within InsertIntoHadoopFsRelation.
- val plan =
- InsertIntoHadoopFsRelationCommand(
- outputPath = outputPath,
- staticPartitions = Map.empty,
- ifPartitionNotExists = false,
- partitionColumns = partitionAttributes,
- bucketSpec = bucketSpec,
- fileFormat = format,
- options = options,
- query = data.logicalPlan,
- mode = mode,
- catalogTable = catalogTable,
- fileIndex = fileIndex)
- sparkSession.sessionState.executePlan(plan).toRdd
+ InsertIntoHadoopFsRelationCommand(
+ outputPath = outputPath,
+ staticPartitions = Map.empty,
+ ifPartitionNotExists = false,
+ partitionColumns = partitionColumns.map(UnresolvedAttribute.quoted),
--- End diff --
Is it safe to use unresolved attributes here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
