Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17972#discussion_r118479964
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
 ---
    @@ -398,6 +398,14 @@ class DecisionTreeClassifierSuite
     
         testDefaultReadWrite(model)
       }
    +
    +  test("intermediate dataset storage level") {
    --- End diff --
    
    Ideally we need to test that the actual storage levels for the intermediate 
RDDs are correct. I did this for ALS - not sure if the same approach might be 
used here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to