Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r118490472
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2015,4 +2015,121 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
checkAnswer(table.filter($"p" === "p1\" and q=\"q1").select($"a"),
Row(4))
}
}
+
+ test("TRIM function-BOTH") {
--- End diff --
Given that we already have tests in sql/SQLQuerySuite, is there any reason
we need these tests in hive/SQLQuerySuite? What's the difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
