Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/18098#discussion_r118550928 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -393,7 +409,30 @@ private[spark] class MesosCoarseGrainedSchedulerBackend( val offerId = offer.getId.getValue val resources = remainingResources(offerId) - if (canLaunchTask(slaveId, resources)) { + var createTask = canLaunchTask(slaveId, resources) + if (hostToLocalTaskCount.nonEmpty) { --- End diff -- It sounds like you're assuming `hostToLocalTaskCount.empty -> there are no executors to launch`. That may be true, but regardless, if that's the case, then `createTask` is already false, so this check is redundant, right? To make this more clear, please factor out this code into some function like `satisfiesLocality`, and instead of calling it here, for consistency, please add it as one of the constraints in `canLaunchTask`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org